Page MenuHomeSoftware Heritage

Prevent OriginMetadataIndexer from sending duplicate revisions to revision_metadata_add.
ClosedPublic

Authored by vlorentz on Feb 5 2019, 12:04 PM.

Diff Detail

Repository
rDCIDX Object indexer
Branch
origin-meta-idx-duplicates2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4155
Build 5477: tox-on-jenkinsJenkins
Build 5476: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 5 2019, 12:04 PM
ardumont accepted this revision.Feb 6 2019, 3:15 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/indexer/metadata.py
312

why not build the 2 lists (rev_metadata, orig_metadata) in one go since you iterate over it here already?

This revision is now accepted and ready to land.Feb 6 2019, 3:15 PM
vlorentz updated this revision to Diff 3422.Feb 6 2019, 5:06 PM
  • Simplify code
vlorentz updated this revision to Diff 3423.Feb 6 2019, 5:07 PM
vlorentz marked 2 inline comments as done.
  • Fix
vlorentz added inline comments.Feb 6 2019, 5:07 PM
swh/indexer/metadata.py
312

Good catch

This revision was automatically updated to reflect the committed changes.