Differential D1070

Prevent name clash when a metadata file has a key named 'dict'.
ClosedPublic
Actions

Authored by vlorentz on Feb 4 2019, 2:08 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T1475: Test more edge cases of metadata indexer mappings

Commits

rDCIDX278af60d877e: Prevent name clash when a metadata file has a key named 'dict'.

Summary

'translate_' + 'dict' conflicts with 'translate_dict'.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 4 2019, 2:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 4 2019, 2:08 PM

vlorentz added a task: T1475: Test more edge cases of metadata indexer mappings.Feb 4 2019, 2:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/310/ for more details.

Harbormaster completed remote builds in B3987: Diff 3376.Feb 4 2019, 2:11 PM

ardumont accepted this revision.Feb 4 2019, 2:31 PM

This revision is now accepted and ready to land.Feb 4 2019, 2:31 PM

rebase

Closed by commit rDCIDX278af60d877e: Prevent name clash when a metadata file has a key named 'dict'. (authored by vlorentz). · Explain WhyFeb 4 2019, 2:44 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B3990: Diff 3379!Feb 4 2019, 2:44 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/312/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/312/console

Revision Contents
Changeset List

Path

Size

swh/

indexer/

metadata_dictionary.py

10 lines

Diff 3380

View Options

swh/indexer/metadata_dictionary.py

Prevent name clash when a metadata file has a key named 'dict'.ClosedPublicActions