Page MenuHomeSoftware Heritage

jenkins: Allow debian build jobs to not download/upload artifact from pypi
AbandonedPublic

Authored by ardumont on Feb 1 2019, 5:12 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

That avoids the 'gbp import-orig' step.
Which avoid to install the pypi-upload [1] setup in the package recipe [2]

for example, there is no reference in [2] about upload-pypi step.

[1] https://forge.softwareheritage.org/source/swh-jenkins-jobs/browse/master/jobs/swh/indexer.yaml$8

[2] https://forge.softwareheritage.org/source/swh-jenkins-jobs/browse/master/jobs/swh/mirakuru.yaml

Diff Detail

Repository
rCJSWH Jenkins jobs
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3968
Build 5209: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 1 2019, 5:12 PM
ardumont edited the summary of this revision. (Show Details)Feb 1 2019, 5:16 PM
ardumont marked an inline comment as done.Feb 1 2019, 6:36 PM
ardumont added inline comments.
jobs/templates/debian/update-for-release.yaml
18

As the default suggests, it's supposed to be on, always.
Especially for the swh-* modules we control (and upload to pypi).

It's only expected to be used for external dependencies as a first draft.
A better solution is always welcome.
Might be just digging around the gbp import-origin step (from update-for-release job) to improve it and not depend on the pypi-upload job?

ardumont retitled this revision from jobs: Allow jobs to not download/upload artifact from pypi to jenkins: Allow debian build jobs to not download/upload artifact from pypi.Feb 3 2019, 6:56 PM
ardumont abandoned this revision.Feb 4 2019, 10:48 AM
ardumont marked an inline comment as done.

I misunderstood the gbp import-orig' step.
Thus download_artifact_from_pypi is badly named here.

The ' step is using the /{name}/pypi-upload/ artifact which is there for swh modules (because we upload them to pypi).
So that job makes sense for swh modules.

I wanted to reuse the job to build external package.
And that step is currently failing in the way i want to build the package.
Not a good reason for this change.

jobs/templates/debian/update-for-release.yaml
18

I misunderstood the step.
And download_artifact_from_pypi is badly named here.
The 'gbp import-orig' step is using the /{name}/pypi-upload artifact which is there for swh modules (because we upload them to pypi).