Page MenuHomeSoftware Heritage
Differential D1066

Allow to override config file name via the SWH_CONFIG_FILENAME env var
ClosedPublic
Actions

Authored by douardda on Feb 1 2019, 3:57 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCOREf3efe0cd6357: Allow to override config file name via the SWH_CONFIG_FILENAME env var
Summary

this will take precedence over the implicit config file scheme.

Related to T1410 and T826

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Feb 1 2019, 3:57 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 1 2019, 3:57 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 1 2019, 3:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/151/ for more details.

Harbormaster completed remote builds in B3964: Diff 3369.Feb 1 2019, 3:58 PM
ardumont accepted this revision.Feb 1 2019, 4:11 PM
ardumont added a subscriber: ardumont.

slowly but surely we progress towards the implicit configuration killing ;)

This revision is now accepted and ready to land.Feb 1 2019, 4:11 PM
douardda added a comment.Feb 1 2019, 5:00 PM
In D1066#22575, @ardumont wrote:

slowly but surely we progress towards the implicit configuration killing ;)

In fact this diff is probably not that useful, the one really needed, for most celery workers in fact, is D1067

douardda added a comment.Feb 6 2019, 10:29 AM
In D1066#22587, @douardda wrote:
In D1066#22575, @ardumont wrote:

slowly but surely we progress towards the implicit configuration killing ;)

In fact this diff is probably not that useful, the one really needed, for most celery workers in fact, is D1067

Well, D1067 won't be enough, this one remains required, eg. for celery (non scheduler) workers like listers, loaders and indexers.

Closed by commit rDCOREf3efe0cd6357: Allow to override config file name via the SWH_CONFIG_FILENAME env var (authored by douardda). · Explain WhyFeb 6 2019, 10:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
core/
2 lines

Diff 3400

View Options

swh/core/config.py

Loading...
About · Developer information · Legal