Page MenuHomeSoftware Heritage

Add tests for the cloud object storage
ClosedPublic

Authored by qcampos on Aug 17 2016, 3:56 PM.

Details

Summary

Create mock classes for the libcloud driver so the objstorage behavior can be checked.

Also, catch a libcloud exception and raise swh exception instead at the lower possible level in the code.

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

qcampos retitled this revision from to Add tests for the cloud object storage.
qcampos updated this object.
qcampos edited the test plan for this revision. (Show Details)

This does not add tests, you defined the backbone to permit to write tests, right?

swh/objstorage/cloud/objstorage_cloud.py
55

have t`o` support

136

will contain

This does not add tests, you defined the backbone to permit to write tests, right?

After @qcampos and I discussed, this is wrong!
There are tests, it's ObjStorageTestFixture which is in charge to run the tests!

This revision is now accepted and ready to land.Aug 26 2016, 12:57 PM
This revision was automatically updated to reflect the committed changes.